Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 )
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/14517/13/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala File java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala: http://gerrit.cloudera.org:8080/#/c/14517/13/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@302 PS13, Line 302: case d: Date => d.toString() : case n: Integer => DateUtil.epochDaysToDateString(n) I'm not a Scala expert, but this looks a bit strange. Why value.asInstanceOf[Date] would return sometimes a Date, but sometimes an Integer instance? Is it possible to unify the type of the returned value so it's always Date? -- To view, visit http://gerrit.cloudera.org:8080/14517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2 Gerrit-Change-Number: 14517 Gerrit-PatchSet: 13 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Sat, 25 Jan 2020 01:01:53 +0000 Gerrit-HasComments: Yes
