Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4523 )
Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE ...................................................................... Patch Set 25: (3 comments) http://gerrit.cloudera.org:8080/#/c/4523/25//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/4523/25//COMMIT_MSG@11 PS25, Line 11: I manually tested this against an old server version without the INSERT_IGNORE operation suport and it returns the correct > Too long. Also 'support', and I think there are two spaces in a row between Done http://gerrit.cloudera.org:8080/#/c/4523/25/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/4523/25/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@171 PS25, Line 171: maybe > may be Done http://gerrit.cloudera.org:8080/#/c/4523/25/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@170 PS25, Line 170: An insert ignore, ignores : * duplicate row errors > How about "An insert ignore will ignore duplicate row errors". Done -- To view, visit http://gerrit.cloudera.org:8080/4523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd Gerrit-Change-Number: 4523 Gerrit-PatchSet: 25 Gerrit-Owner: Brock Noland <br...@phdata.io> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Brock Noland <br...@phdata.io> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 18 Feb 2020 16:03:27 +0000 Gerrit-HasComments: Yes
