Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 )
Change subject: [java] KUDU-2972: add Kudu Ranger plugin ...................................................................... Patch Set 6: > Patch Set 6: > > > > How do you feel about predicating this change on MiniRanger support? The > > > mock-based testing is good, but as it stands we lack any coverage that > > > the Ranger plugin internals themselves are working given our input. > > > > Yeah, I think it will be great if we can enable MiniRanger for Java testing > > as well. However as Ranger admin server requires external database config > > (e.g. postgres, mysql), it seems hard for Java test to have a proper setup > > for MiniRanger. On the other hand, we will have MiniRanger support in C++ > > which should have enough coverage from end-to-end (although again it would > > be better to have MiniRanger test coverage in Java). > > Right, I didn't mean to suggest that Java tests should be controlling > MiniRanger directly; rather that they'd interact with an external mini > cluster (via the control shell protocol) as usual, and the cluster would > include a MiniRanger. And, in the context of this patch, whether we should > hit pause on it and go work on MiniRanger support, so that we can actually > show end-to-end coverage on this patch before merging it. > > BTW, are you saying it won't be possible to deploy a MiniRanger _without_ an > RDBMS? Or can Ranger support simple file-based databases like sqlite or > Derby? Setting up a full-fledged RDBMS is a huge pain, and I'm not even sure > whether it's possible to do it without root. I see, that is a good idea. Thanks for bringing it up! In the context of the patch, I would prefer to have the patch landed first as Attila is working on the RangerAuthorizationProvider which depends on it and I can do a follow up patch for additional test coverage once MiniRanger is ready (I think Attila has started to work on MiniRanger support). However, I'm fine with pausing this patch if you have a strong opinion. Yeah, unfortunately, Ranger requires RDBMS and file-based databases like sqlite or Derby is not supported as what I heard from Ranger team. I know Impala set up postgres for Ranger integration test (https://github.com/apache/impala/commit/0cb7187841780cabe368607ff559e493be59db22#diff-06f06be34aa24e93239793a45e6ad6fb), but I stopped following up as Attila is working on it. -- To view, visit http://gerrit.cloudera.org:8080/15074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c995ac1a48ebf57667231cd3a82d3794f6ddf8d Gerrit-Change-Number: 15074 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 18 Feb 2020 20:05:16 +0000 Gerrit-HasComments: No
