Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: KUDU-2780: create thread for auto-rebalancing ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/14177/18/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/18/src/kudu/master/auto_rebalancer-test.cc@269 PS18, Line 269: ASSERT_LT(0, iterations); : }); : } : > >If there's a discrepancy between the number of tservers the TSManager beli Done http://gerrit.cloudera.org:8080/#/c/14177/19/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/14177/19/src/kudu/master/auto_rebalancer.cc@391 PS19, Line 391: for (const auto& r : locs_pb.interned_replicas()) { : if (r.role() == RaftPeerPB::LEADER) { : int index = r.ts_info_idx(); : const TSInfoPB ts_info = *(ts_infos_dict.ts_info_pbs[index]); : *leader_uuid = ts_info.permanent_uuid(); : const auto& addr = ts_info.rpc_addresses(0); : leader_hp->set_host(addr.host()); : leader_hp->set_port(addr.port()); : break; : } : } : return Status::OK(); > Per the comment methods: Done http://gerrit.cloudera.org:8080/#/c/14177/19/src/kudu/master/auto_rebalancer.cc@426 PS19, Line 426: return Status::NotFound("Could not find leader replica's tserver"); > nit: would be nice to include the leader's UUID in this error message Done -- To view, visit http://gerrit.cloudera.org:8080/14177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4 Gerrit-Change-Number: 14177 Gerrit-PatchSet: 19 Gerrit-Owner: Hannah Nguyen <hannah.ngu...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hannah Nguyen <hannah.ngu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 11 Mar 2020 17:40:10 +0000 Gerrit-HasComments: Yes
