Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 )
Change subject: [client] Add C++ API to accept BlockBloomFilter directly ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15424/1/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/15424/1/src/kudu/client/client.cc@1025 PS1, Line 1025: reinterpret_cast<BlockBloomFilterBufferAllocatorIf*>(allocator.mutable_data()); > Done. Though one downside is changing types of allocator and bloom_filters Hmm, given that, the earlier approach was probably better, as we're not mutating the Slice (or the vector), so cref conveys the correct semantics to the user. Sorry; didn't realize you'd have to change that. -- To view, visit http://gerrit.cloudera.org:8080/15424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea85e3da8fe55f78e49a80439e6af723aa3d970b Gerrit-Change-Number: 15424 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Mar 2020 22:22:20 +0000 Gerrit-HasComments: Yes
