Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15540 )
Change subject: [rpc] Add RPC feature flag for Bloom filter predicate ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15540/2/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/15540/2/src/kudu/client/scanner-internal.cc@358 PS2, Line 358: controller_.RequireServerFeature(TabletServerFeatures::BLOOM_FILTER_PREDICATE); I think we should still set this on scan continuations; we just shouldn't need to call the (mildly) expensive ContainsBloomFilterPredicate to do so. Meaning, we should be able to look at the request we just sent and pass the same feature along if it was set in the request. Come to think of it, we could do this for all scan-related features. -- To view, visit http://gerrit.cloudera.org:8080/15540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87c6bac1e9f77a9ea306ab00404e5101a0c583b9 Gerrit-Change-Number: 15540 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Mar 2020 06:43:16 +0000 Gerrit-HasComments: Yes
