Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15525 )
Change subject: [ranger] allow subprocess to log to a file ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15525/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15525/1//COMMIT_MSG@7 PS1, Line 7: [ranger] allow subprocess to log to a file > As it stands, subprocess logging will be piped back to the originating Kudu I am also curious about the motivation of this patch. I think it would be preferable to have the logs in the maser server logs if possible instead of a separate file. http://gerrit.cloudera.org:8080/#/c/15525/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerSubprocessMain.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerSubprocessMain.java: http://gerrit.cloudera.org:8080/#/c/15525/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerSubprocessMain.java@41 PS1, Line 41: if (conf.getDebugLogging()) { If we decide to go this route could we allow configuring the path to the log4j configuration on the master and start the java subprocess with it? Then all log4j configuration options are available and no custom code is needed. Example: java cp .... -Dlog4j.configuration={path to file} -- To view, visit http://gerrit.cloudera.org:8080/15525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e0c64a05ff936044807df7efc698569f494f0e7 Gerrit-Change-Number: 15525 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Mar 2020 14:23:04 +0000 Gerrit-HasComments: Yes
