Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15550 )
Change subject: wire_protocol: some simplification and optimization for rowwise encoding ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15550/2/src/kudu/common/rowblock.h File src/kudu/common/rowblock.h: http://gerrit.cloudera.org:8080/#/c/15550/2/src/kudu/common/rowblock.h@108 PS2, Line 108: // In the case that all rows are selected, sets *selected to 'boost::none' > It feels a little unintuitive that none == all, but as long as we document I felt similarly, but I also don't mind it if it's documented. Alternatively, we could forego optionality entirely and return a bool indicating whether all rows were selected or something, but I don't feel strongly about it. http://gerrit.cloudera.org:8080/#/c/15550/2/src/kudu/common/wire_protocol.h File src/kudu/common/wire_protocol.h: http://gerrit.cloudera.org:8080/#/c/15550/2/src/kudu/common/wire_protocol.h@164 PS2, Line 164: protobuf and nit: this no longer applies -- To view, visit http://gerrit.cloudera.org:8080/15550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24dfb1bd036fde514ca6494bae0ddc171dd225dd Gerrit-Change-Number: 15550 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 25 Mar 2020 04:12:04 +0000 Gerrit-HasComments: Yes
