Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h ...................................................................... Patch Set 2: (1 comment) FYI there's another outstanding patch that also bumps the file: https://gerrit.cloudera.org/c/14964/7/src/kudu/gutil/linux_syscall_support.h It hasn't moved in a while so don't feel like you need to coordinate, but it'd be good to compare the version you're bumping to and that version just to make sure they're roughly the same (or ideally, exactly the same). http://gerrit.cloudera.org:8080/#/c/15557/2/src/kudu/gutil/spinlock_linux-inl.h File src/kudu/gutil/spinlock_linux-inl.h: PS2: Here and elsewhere, use nullptr in C++ code. -- To view, visit http://gerrit.cloudera.org:8080/15557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058 Gerrit-Change-Number: 15557 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Mar 2020 20:11:05 +0000 Gerrit-HasComments: Yes
