Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15483 )

Change subject: KUDU-3079 Add MiniRanger
......................................................................


Patch Set 50:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15483/50/src/kudu/postgres/mini_postgres.cc
File src/kudu/postgres/mini_postgres.cc:

http://gerrit.cloudera.org:8080/#/c/15483/50/src/kudu/postgres/mini_postgres.cc@99
PS50, Line 99: Status MiniPostgres::Stop() {
Stop() called twice in a row will SIGSEGV.


http://gerrit.cloudera.org:8080/#/c/15483/50/src/kudu/ranger/mini_ranger.cc
File src/kudu/ranger/mini_ranger.cc:

http://gerrit.cloudera.org:8080/#/c/15483/50/src/kudu/ranger/mini_ranger.cc@59
PS50, Line 59: Status MiniRanger::Stop() {
If you call this twice in a row, it'll SIGSEGV.


http://gerrit.cloudera.org:8080/#/c/15483/50/src/kudu/ranger/mini_ranger.cc@220
PS50, Line 220:   LOG(INFO) << Substitute("Ranger started in $0ms",
              :                           (MonoTime::Now() - 
start).ToMilliseconds());
If you want to measure the amount of time a block of code takes to run, use 
LOG_TIMING (from stopwatch.h).



--
To view, visit http://gerrit.cloudera.org:8080/15483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ab1eb8abe71c074c26b286073442882e101bc6
Gerrit-Change-Number: 15483
Gerrit-PatchSet: 50
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 25 Mar 2020 20:21:31 +0000
Gerrit-HasComments: Yes

Reply via email to