Hello Andrew Wong, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15560

to review the following change.


Change subject: Add functionality to serialize a RowBlock into columnar format
......................................................................

Add functionality to serialize a RowBlock into columnar format

This adds the core functionality to take a RowBlock and convert it into
a set of buffers for each column: the cell data, the null bitmap, and
the indirect (string) data.

This also updates wire_protocol-test to add coverage for nulls and
unselected rows, and adds a comparison benchmark. The columnar code path
is 4-5x faster in the best case, and in the worst case only 30% slower
that the existing row-wise code path.

Some follow-up commits will add further optimizations.

Change-Id: I287a8aa6736f19816b0edbe16409c01f35c0319e
---
M src/kudu/common/columnar_serialization.cc
M src/kudu/common/columnar_serialization.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/util/faststring.h
4 files changed, 477 insertions(+), 113 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/15560/1
--
To view, visit http://gerrit.cloudera.org:8080/15560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I287a8aa6736f19816b0edbe16409c01f35c0319e
Gerrit-Change-Number: 15560
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>

Reply via email to