Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 )
Change subject: iwyu: codebase-wide fixes based on libcpp ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/minidump.cc File src/kudu/util/minidump.cc: http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/minidump.cc@37 PS3, Line 37: #include <breakpad/client/linux/handler/minidump_descriptor.h> > I cherry-picked this patch on macOS catalina and I see this. Yeah, the same story. It seems these breakpad headers should be moved under the #if defined(__linux__) ... #endif section above. At least I was able to compile the code successfully after doing so. -- To view, visit http://gerrit.cloudera.org:8080/15543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354 Gerrit-Change-Number: 15543 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 26 Mar 2020 03:09:35 +0000 Gerrit-HasComments: Yes
