Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15572 )

Change subject: KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE 
mode
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15572/1/src/kudu/util/debug-util-test.cc
File src/kudu/util/debug-util-test.cc:

http://gerrit.cloudera.org:8080/#/c/15572/1/src/kudu/util/debug-util-test.cc@125
PS1, Line 125: const char*
Just curious: making this constexpr would re-introduce the issue back?



--
To view, visit http://gerrit.cloudera.org:8080/15572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcd76f42b70bfc77ab18e8163a367f89eaad3e9
Gerrit-Change-Number: 15572
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Sat, 28 Mar 2020 00:39:31 +0000
Gerrit-HasComments: Yes

Reply via email to