Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 )
Change subject: gutil: remove callback and bind from the codebase ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15583/2/docs/contributing.adoc File docs/contributing.adoc: http://gerrit.cloudera.org:8080/#/c/15583/2/docs/contributing.adoc@320 PS2, Line 320: All code should use C++11 lambdas to capture and manage functors. Functions that : take a lambda as an argument should use `std::function` as the argument's type. nit: maybe explicitly state we prefer lambdas over std::bind, and mention why? Are the points about ref-counting no longer a consideration? -- To view, visit http://gerrit.cloudera.org:8080/15583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb53730f9c33b37415b22fcc775266467116b9 Gerrit-Change-Number: 15583 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Comment-Date: Mon, 30 Mar 2020 06:14:49 +0000 Gerrit-HasComments: Yes
