Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc@383 PS2, Line 383: Status s = subprocess_->Execute(req_list, &resp_list); : if (s.ok()) { > If we failed to execute, why not actually return an error? My point before To be clear, I'm advocating for moving these empty list checks into the RangerAuthzProvider. -- To view, visit http://gerrit.cloudera.org:8080/15609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176 Gerrit-Change-Number: 15609 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 31 Mar 2020 06:48:46 +0000 Gerrit-HasComments: Yes
