Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15615
to look at the new patch set (#2).
Change subject: [subprocess] Fix shutdown behavior
......................................................................
[subprocess] Fix shutdown behavior
Prior to this commit the subprocess didn't actually shut down when its
input stream was closed. This wasn't much of a problem on Linux where
PDEATHSIG is set on the child process, but as it's not supported on Mac,
whenever the master is shut down/crashes the subprocess stays alive.
This commit changes the behavior in the subprocess to wrap the
IOException in KuduSubprocessException instead of simply breaking the
loop (in which case the other threads would keep running uninterrupted),
and the futures' exception handler exits the program.
Change-Id: Ia84bff891eaff667d7b22e89c66f24980ad76d70
---
M
java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/MessageReader.java
M
java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/15615/2
--
To view, visit http://gerrit.cloudera.org:8080/15615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia84bff891eaff667d7b22e89c66f24980ad76d70
Gerrit-Change-Number: 15615
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
