Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 )
Change subject: client: add support for columnar format scan ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15622/2/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/15622/2/src/kudu/client/client.cc@1808 PS2, Line 1808: RETURN_NOT_OK(data_->OpenNextTablet(deadline, &blacklist)); : if (data_->data_in_open_) { : // Avoid returning an empty batch in between tablets if we have data : // we can return from this call. : return NextBatch(batch_data); : } > this can't loop -- if it recurses once, the 'data_in_open_' case will trigg Ack http://gerrit.cloudera.org:8080/#/c/15622/2/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/15622/2/src/kudu/client/scanner-internal.cc@790 PS2, Line 790: : unique_ptr<ColumnarRowBlockPB> resp_data(response->release_columnar_data()); : if (!resp_data) { > can't really because resp_data_ is an instance, not a pointer. So we still Ack -- To view, visit http://gerrit.cloudera.org:8080/15622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69ec4487c78b872e7b9eba5facdd44cfd6b8f4fa Gerrit-Change-Number: 15622 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 01 Apr 2020 19:09:21 +0000 Gerrit-HasComments: Yes
