Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 )
Change subject: [subprocess] Fix shutdown behavior ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15615/5/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java: http://gerrit.cloudera.org:8080/#/c/15615/5/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@116 PS5, Line 116: // TODO(abukor): Refactor code so the futures can be cance > Can you comment that we are forcing the program to exit when the reader fut Done -- To view, visit http://gerrit.cloudera.org:8080/15615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia84bff891eaff667d7b22e89c66f24980ad76d70 Gerrit-Change-Number: 15615 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 02 Apr 2020 09:24:00 +0000 Gerrit-HasComments: Yes
