Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15628 )
Change subject: ranger: enable log4j2 logging to files ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15628/5/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessConfiguration.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessConfiguration.java: http://gerrit.cloudera.org:8080/#/c/15628/5/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessConfiguration.java@252 PS5, Line 252: > Should this be the default if a file is not provided? If we remove the abil Yeah, I'm going to punt on this for now; the new patch doesn't touch this code at all. http://gerrit.cloudera.org:8080/#/c/15628/5/java/kudu-subprocess/src/main/resources/log4j2.properties File java/kudu-subprocess/src/main/resources/log4j2.properties: http://gerrit.cloudera.org:8080/#/c/15628/5/java/kudu-subprocess/src/main/resources/log4j2.properties@30 PS5, Line 30: > If we allow generating the log4j conf in the master based on my review in t Done -- To view, visit http://gerrit.cloudera.org:8080/15628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7efa631832c219fce214304538e6ab6442062752 Gerrit-Change-Number: 15628 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 Apr 2020 08:10:49 +0000 Gerrit-HasComments: Yes
