Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15639 )
Change subject: remove last vestiges of boost::bind, boost::function, and std::bind ...................................................................... Patch Set 1: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/15639/1/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/15639/1/src/kudu/client/client.cc@1684 PS1, Line 1684: // CloseCallback::Callback() deletes the closer. Thank you for adding this comment. http://gerrit.cloudera.org:8080/#/c/15639/1/src/kudu/rpc/reactor.h File src/kudu/rpc/reactor.h: http://gerrit.cloudera.org:8080/#/c/15639/1/src/kudu/rpc/reactor.h@166 PS1, Line 166: void AsyncHandler(ev::async& watcher, int revents); > warning: non-const reference parameter 'watcher', make it const or use a po nit: while you are here, maybe add a comment that the signature of this function is dictated by libev? http://gerrit.cloudera.org:8080/#/c/15639/1/src/kudu/rpc/reactor.h@169 PS1, Line 169: void TimerHandler(ev::timer& watcher, int revents); > warning: non-const reference parameter 'watcher', make it const or use a po ditto -- To view, visit http://gerrit.cloudera.org:8080/15639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd876f200f680f3d3617d78852f1e0a9c5649372 Gerrit-Change-Number: 15639 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 03 Apr 2020 20:26:20 +0000 Gerrit-HasComments: Yes
