Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support ...................................................................... Patch Set 1: (7 comments) Python test kudu.tests.test_scanner.TestScanner.test_scanner_to_pandas_types is failing: http://jenkins.kudu.apache.org/job/kudu-gerrit/21294/BUILD_TYPE=DEBUG/testReport/junit/kudu.tests.test_scanner/TestScanner/test_scanner_to_pandas_types/ http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py File python/kudu/util.py: http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@186 PS1, Line 186: Converts If following the same style of the docs as for the other functions in this file, this should be 'Convert'. http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@188 PS1, Line 188: of seconds per day (86400) nit: add a period http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@189 PS1, Line 189: extra spaces http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@190 PS1, Line 190: Returns Could you add information about the parameter of this function into the doc header using the same style as in other functions? http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@198 PS1, Line 198: Converts Convert http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@199 PS1, Line 199: the number of days since the unix epoch nit: add a period http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@203 PS1, Line 203: timestamp Is this a mismatch between the actual name of the parameter and the documented name? -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 04 Apr 2020 00:36:53 +0000 Gerrit-HasComments: Yes
