Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15628 )
Change subject: ranger: enable log4j2 logging to files ...................................................................... ranger: enable log4j2 logging to files This patch enables Kudu to generate a log4j2 properties file and pass it to the Ranger client. This file is created in a directory specified by the new --ranger_logging_config_dir flag, which, by default, will direct the properties file to --log_dir. If the properties file already exists, the existing file is honored. This means a file will not be regenerated if one has already been generated -- I will add a follow up patch to allow users to overwrite the file. This properties file will direct logs to the directory pointed to by --log_dir, and will honor the existing --max_log_files and --max_log_size flags. I've found logging to stdout and adjusting log42j log-level to be useful, so this also adds --ranger_logtostdout and --ranger_log_level for these respectively. I opted not to use the glog --minloglevel flag since they don't quite map to log4j2 log levels (e.g. glog doesn't have debug-level logging). I manually tested that an existing properties file that has been modified will be honored. Here's what's in a Ranger-configured Kudu master's log directory: kudu-master.INFO -> kudu-master.awong-MBP16-21621.local.awong.log.INFO.20200403-122527.17165 kudu-master.awong-MBP16-21621.local.awong.diagnostics.20200403-122527.0.17165 kudu-master.awong-MBP16-21621.local.awong.log.INFO.20200403-122527.17165 kudu-ranger-subprocess-log4j2.properties kudu-ranger-subprocess.awong-MBP16-21621.local.log Change-Id: I7efa631832c219fce214304538e6ab6442062752 Reviewed-on: http://gerrit.cloudera.org:8080/15628 Reviewed-by: Grant Henke <granthe...@apache.org> Tested-by: Andrew Wong <aw...@cloudera.com> --- M java/kudu-subprocess/build.gradle M src/kudu/ranger/mini_ranger.cc M src/kudu/ranger/mini_ranger.h M src/kudu/ranger/ranger_client-test.cc M src/kudu/ranger/ranger_client.cc M src/kudu/subprocess/CMakeLists.txt A src/kudu/subprocess/subprocess_proxy.cc M src/kudu/subprocess/subprocess_proxy.h M src/kudu/util/env.h 9 files changed, 374 insertions(+), 65 deletions(-) Approvals: Grant Henke: Looks good to me, approved Andrew Wong: Verified -- To view, visit http://gerrit.cloudera.org:8080/15628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7efa631832c219fce214304538e6ab6442062752 Gerrit-Change-Number: 15628 Gerrit-PatchSet: 12 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
