Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15650 )

Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client-test.cc@371
PS2, Line 371:                                            &matches));
> How about using Env::Glob for this and the regexp stuff?
Done



--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 04 Apr 2020 21:45:59 +0000
Gerrit-HasComments: Yes

Reply via email to