Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15670 )
Change subject: [ranger] update description of Ranger integration related flags ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15670/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15670/1/src/kudu/ranger/ranger_client.cc@55 PS1, Line 55: in the master I thought that scan operations are authorized by tablet servers using authz tokens, no? Maybe, drop this piece, if so? http://gerrit.cloudera.org:8080/#/c/15670/1/src/kudu/ranger/ranger_client.cc@56 PS1, Line 56: ranger_java_path nit: I think it would be easier to read if it was written as --ranger_java_path Same of other flags mentioned in these docs. -- To view, visit http://gerrit.cloudera.org:8080/15670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If782f022ada6606b31d720f1dba793af45e8003e Gerrit-Change-Number: 15670 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Apr 2020 16:16:10 +0000 Gerrit-HasComments: Yes