Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 )
Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/client/columnar_scan_batch.h File src/kudu/client/columnar_scan_batch.h: http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/client/columnar_scan_batch.h@45 PS3, Line 45: but without the alignment and padding guarantees that are made by : /// the Arrow IPC serialization. > well, they might be important for in-memory on some architectures as well ( Hrm, it's probably worth mentioning those repercussions then if some architectures won't be able to run this. http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/common/columnar_serialization.cc File src/kudu/common/columnar_serialization.cc: http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/common/columnar_serialization.cc@615 PS3, Line 615: SelectedRows sel = block.selection_vector()->GetSelectedRows(); > Added the short circuit, but not sure about the dcheck. Is there sometihng Right, it seems fine to fall through. It'd just be a signal to readers what to expect, and that we're short-circuiting somewhere upstream. I'm ok without it though. http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/common/rowblock.h File src/kudu/common/rowblock.h: http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/common/rowblock.h@265 PS3, Line 265: num_selected > gonna disagree on this one -- the compiler will see that the load of all_se Ack -- To view, visit http://gerrit.cloudera.org:8080/15660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadf728744feb83f5980e62bea4fd7634a1a52467 Gerrit-Change-Number: 15660 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 07 Apr 2020 17:27:31 +0000 Gerrit-HasComments: Yes
