Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 )
Change subject: cfile: change BlockBuilder API to yield a vector of Slices ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15042/6/src/kudu/cfile/encoding-test.cc File src/kudu/cfile/encoding-test.cc: http://gerrit.cloudera.org:8080/#/c/15042/6/src/kudu/cfile/encoding-test.cc@367 PS6, Line 367: with unsigned types nit: Isn't this instantiated by IntEncodingTest with both signed and unsigned ints? http://gerrit.cloudera.org:8080/#/c/15042/6/src/kudu/cfile/encoding-test.cc@373 PS6, Line 373: char, short nit: I might be missing something, but isn't this only called with int types? Why might we see 'char'? -- To view, visit http://gerrit.cloudera.org:8080/15042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc7a5f148a4a43cedac2428f4c1a18d0f93a10db Gerrit-Change-Number: 15042 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 07 Apr 2020 19:20:14 +0000 Gerrit-HasComments: Yes
