Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15680 )
Change subject: columnar_serialization: fix optimized GCC build ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15680/2/src/kudu/common/columnar_serialization.cc File src/kudu/common/columnar_serialization.cc: http://gerrit.cloudera.org:8080/#/c/15680/2/src/kudu/common/columnar_serialization.cc@389 PS2, Line 389: long long int > Since this is breaking some builds I will merge and leave that comment and SGTM I was just curious whether it will break macOS build because of that. But it seems it's all right now, if I'm not mistaken. -- To view, visit http://gerrit.cloudera.org:8080/15680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7 Gerrit-Change-Number: 15680 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 08 Apr 2020 20:51:39 +0000 Gerrit-HasComments: Yes
