Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 )
Change subject: encoding-test: Clean up bitshuffle tests a little ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/15043/9/src/kudu/util/random_util.h File src/kudu/util/random_util.h: http://gerrit.cloudera.org:8080/#/c/15043/9/src/kudu/util/random_util.h@146 PS9, Line 146: exception > I think comment is better placed close to the line that raises ASAN/UBSAN w It seems convenient to place it where the suppression is, especially for such a small function. When I read the code here, I'm thinking more about random number generation than I am about ASAN, so this comment seems a little out of place, at least without more context. Maybe be a bit more explicit here then: "Hence the ASAN suppression for this template" or somesuch. -- To view, visit http://gerrit.cloudera.org:8080/15043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b7bee1f952c46c09df5102ac1916141c6935284 Gerrit-Change-Number: 15043 Gerrit-PatchSet: 11 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 09 Apr 2020 01:21:32 +0000 Gerrit-HasComments: Yes
