Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 )
Change subject: net: make Sockaddr more generic for other address families ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Looks like a step in the right direction for this API. http://gerrit.cloudera.org:8080/#/c/15690/2/src/kudu/util/net/sockaddr.h File src/kudu/util/net/sockaddr.h: http://gerrit.cloudera.org:8080/#/c/15690/2/src/kudu/util/net/sockaddr.h@131 PS2, Line 131: union { Clearly sockaddr_storage was designed to be used in this way but I never knew about this. Very nice. -- To view, visit http://gerrit.cloudera.org:8080/15690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifff57e13a0e9b86b191d776ead67371b1e2ed4e3 Gerrit-Change-Number: 15690 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Apr 2020 03:58:07 +0000 Gerrit-HasComments: Yes
