Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 )
Change subject: KUDU-3078 Add Ranger tests to master_authz-itest ...................................................................... Patch Set 13: (8 comments) http://gerrit.cloudera.org:8080/#/c/15681/1/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/15681/1/src/kudu/integration-tests/master_authz-itest.cc@1151 PS1, Line 1151: zITestBase::SetUp()); > How do you feel about adding a TODO to refactor it once we support C++14? W The latest patchset seems to be working with the approach described here. http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/integration-tests/master_authz-itest.cc@540 PS7, Line 540: > We should use ParseRangerTableIdentifier? Done http://gerrit.cloudera.org:8080/#/c/15681/9/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/15681/9/src/kudu/integration-tests/master_authz-itest.cc@245 PS9, Line 245: > warning: method 'CreateKuduTable' can be made static [readability-convert-m Done http://gerrit.cloudera.org:8080/#/c/15681/9/src/kudu/integration-tests/master_authz-itest.cc@285 PS9, Line 285: KuduSchema schema; > warning: method 'CheckTable' can be made static [readability-convert-member Done http://gerrit.cloudera.org:8080/#/c/15681/9/src/kudu/integration-tests/master_authz-itest.cc@287 PS9, Line 287: unique_ptr<KuduTableCreator> table_creator(client->NewTableCreator()); > warning: parameter 'user' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/15681/9/src/kudu/integration-tests/master_authz-itest.cc@288 PS9, Line 288: if (timeout.Initialized()) { > warning: parameter 'cluster' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/15681/9/src/kudu/integration-tests/master_authz-itest.cc@568 PS9, Line 568: AuthorizationPolicy policy; > warning: parameter 'cluster' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/15681/9/src/kudu/integration-tests/master_authz-itest.cc@572 PS9, Line 572: SleepFor(MonoDelta::FromMilliseconds(1500)); > warning: parameter 'cluster' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/15681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25dc67516cd61f0624914989f8db4c4f94d7e3bf Gerrit-Change-Number: 15681 Gerrit-PatchSet: 13 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 09 Apr 2020 04:58:08 +0000 Gerrit-HasComments: Yes
