Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15714 )
Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger ...................................................................... Patch Set 4: Code-Review+2 (3 comments) LGTM, just a few nits. http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc File src/kudu/integration-tests/ts_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc@269 PS4, Line 269: class TSAuthzITestHarness nit: add a short description for this test harness? http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc@301 PS4, Line 301: virtual Status GrantTablePrivilege nit: we may want to call it out by granting table level privilege, column level privilege is also granted for Sentry and Ranger. http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc@692 PS4, Line 692: No such behavior exists in Ranger No such behavior exists in Ranger with short polling intervals in Ranger client? -- To view, visit http://gerrit.cloudera.org:8080/15714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d Gerrit-Change-Number: 15714 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 13 Apr 2020 05:47:20 +0000 Gerrit-HasComments: Yes
