Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15767 )
Change subject: [util] Don't use static function ptrs for member functions in BlockBloom filter ...................................................................... Patch Set 2: (1 comment) > Patch Set 1: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/15767/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15767/1//COMMIT_MSG@19 PS1, Line 19: > Thanks for the info. My question was about whether you were able to repro Without this fix, Impala integration is reliably able to reproduce the crash. The test case(s) basically includes running a bunch of different queries. With this fix, Impala integration is unable to reproduce the crash. So yes, this change reliably fixes the issue. If by previous revision you mean "(this is same as the change before introduction of OrEqual functions)", no we haven't explicitly tested Impala integration with code from before the "OrEqual" function introduction change. https://gerrit.cloudera.org/c/15450/ -- To view, visit http://gerrit.cloudera.org:8080/15767 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39703fd1a7e256ff60ef86d0b370590fbb526380 Gerrit-Change-Number: 15767 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2020 17:18:09 +0000 Gerrit-HasComments: Yes
