Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15880 )
Change subject: [authorization] Remove the Sentry integration ...................................................................... Patch Set 7: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/15880/7/src/kudu/integration-tests/ts_authz-itest.cc File src/kudu/integration-tests/ts_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/15880/7/src/kudu/integration-tests/ts_authz-itest.cc@285 PS7, Line 285: Grants privileges on the given table/column. I think we still want to mention that 'if granting privileges on a table, these grant privileges on the table and all columns in that table.' http://gerrit.cloudera.org:8080/#/c/15880/7/src/kudu/ranger/ranger_client.h File src/kudu/ranger/ranger_client.h: http://gerrit.cloudera.org:8080/#/c/15880/7/src/kudu/ranger/ranger_client.h@67 PS7, Line 67: A privilege scope can imply another following rules defined in : // Implies(). nit: The privilege scope can indicates the hierarchy of authorizables (database -> table -> column). -- To view, visit http://gerrit.cloudera.org:8080/15880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If40a6f2c88721ff3721cf148a9c609102705ae8b Gerrit-Change-Number: 15880 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 07 May 2020 21:44:35 +0000 Gerrit-HasComments: Yes
