Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15870 )
Change subject: tablet: update "transaction" methods to use "op" terminology ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/consensus/consensus.proto File src/kudu/consensus/consensus.proto: http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/consensus/consensus.proto@417 PS2, Line 417: transaction. operation? http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/consensus/pending_rounds.h File src/kudu/consensus/pending_rounds.h: http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/consensus/pending_rounds.h@75 PS2, Line 75: transaction This and other places below. http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/consensus/raft_consensus.cc@1463 PS2, Line 1463: transactions Same here http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/master/sys_catalog.cc@489 PS2, Line 489: new tablet::WriteOpState(tablet_replica_.get(), : &req, : nullptr, // No RequestIdPB : &resp)); Alignment here and bunch of places below. This is where using an IDE would help as it would automatically adjust alignment as well as part of refactoring. http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/tablet/tablet_replica.h File src/kudu/tablet/tablet_replica.h: http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/tablet/tablet_replica.h@224 PS2, Line 224: Transaction::TraceType trace_type, : std::vector<consensus::OpStatusPB>* out) Alignment http://gerrit.cloudera.org:8080/#/c/15870/2/src/kudu/tablet/tablet_replica.h@258 PS2, Line 258: Status NewLeaderOpDriver(std::unique_ptr<Transaction> transaction, : scoped_refptr<OpDriver>* driver); : : Status NewReplicaOpDriver(std::unique_ptr<Transaction> transaction, : scoped_refptr<OpDriver>* driver); Alignment -- To view, visit http://gerrit.cloudera.org:8080/15870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 Gerrit-Change-Number: 15870 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 08 May 2020 17:32:52 +0000 Gerrit-HasComments: Yes
