Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15897 )
Change subject: docs: add Ranger integration ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/15897/1/docs/security.adoc File docs/security.adoc: http://gerrit.cloudera.org:8080/#/c/15897/1/docs/security.adoc@384 PS1, Line 384: should not be enabled nit: "can not be" as it's actually enforced. Also consider adding a similar note to the Sentry section. http://gerrit.cloudera.org:8080/#/c/15897/1/docs/security.adoc@391 PS1, Line 391: are nit: that are http://gerrit.cloudera.org:8080/#/c/15897/1/docs/security.adoc@468 PS1, Line 468: may facilitate nit: add an explanation when this is necessary (backup, checksum scan, etc), and what are the potential drawbacks (admins who can usually access the kudu keytab can do anything) http://gerrit.cloudera.org:8080/#/c/15897/1/docs/security.adoc@473 PS1, Line 473: configurations nit: also add an explanation what this is for http://gerrit.cloudera.org:8080/#/c/15897/1/docs/security.adoc@486 PS1, Line 486: <property> isn't tag.download.auth.users also necessary? or is that only for tag-based which we don't support for now anyway? http://gerrit.cloudera.org:8080/#/c/15897/1/docs/security.adoc@518 PS1, Line 518: can determine nit: to set -- To view, visit http://gerrit.cloudera.org:8080/15897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad9476f18267c1e14a73f893fd812674c955eee2 Gerrit-Change-Number: 15897 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 May 2020 13:12:39 +0000 Gerrit-HasComments: Yes