Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15909 )
Change subject: WIP [tools] multiple tablet ids in 'local_replica delete' ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15909/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15909/1//COMMIT_MSG@10 PS1, Line 10: specified and processed at once > Right now those identifiers have to be specified as a comma-separated list Good points. Perhaps they could be follow-up changes. http://gerrit.cloudera.org:8080/#/c/15909/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/15909/1/src/kudu/tools/kudu-tool-test.cc@2771 PS1, Line 2771: const not needed with constexpr http://gerrit.cloudera.org:8080/#/c/15909/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/15909/1/src/kudu/tools/tool_action_common.cc@199 PS1, Line 199: List lower case list -- To view, visit http://gerrit.cloudera.org:8080/15909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0e509d1775be2a728e4e3b10c724c1f15a96ec1 Gerrit-Change-Number: 15909 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 May 2020 18:00:07 +0000 Gerrit-HasComments: Yes
