Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15920
to review the following change.
Change subject: rebalancer: throttle logging when building cluster info
......................................................................
rebalancer: throttle logging when building cluster info
I enabled the auto-rebalancer on a cluster with many single-replica
tablets and was met with hundreds of messages like the following in very
short bursts:
I0514 16:24:53.469353 151489 rebalancer.cc:325] tablet
0bc9157245694b57a313d1e032093393 of table
'default.loadgen_auto_24bd8866af594df9b9d2185c77ff0d5c'
(0d852b00af434a1980b83e63da3d984a) has single replica, skipping
I0514 16:24:53.469357 151489 rebalancer.cc:325] tablet
1f9507a576dd4115b445faac37b9fcf3 of table
'default.loadgen_auto_24bd8866af594df9b9d2185c77ff0d5c'
(0d852b00af434a1980b83e63da3d984a) has single replica, skipping
I0514 16:24:53.469362 151489 rebalancer.cc:325] tablet
65c794016e3a4e8eb635a3764e3e33a7 of table
'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9'
(49599b5cee6f48308425dafd04519b02) has single replica, skipping
I0514 16:24:53.469367 151489 rebalancer.cc:325] tablet
20910b83145f4e7c83b6d8c6885e423b of table
'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9'
(49599b5cee6f48308425dafd04519b02) has single replica, skipping
I0514 16:24:53.469373 151489 rebalancer.cc:325] tablet
577024c5dea74edd8f286de9d5b73b41 of table
'default.loadgen_auto_32c3519a594f42df9a9c5d753db437a9'
(49599b5cee6f48308425dafd04519b02) has single replica, skipping
This throttles such logs to display once every 10 seconds at most.
Change-Id: I93007b50213244c14e47fc6e913415fad7698057
---
M src/kudu/rebalance/rebalancer.cc
1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/15920/1
--
To view, visit http://gerrit.cloudera.org:8080/15920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93007b50213244c14e47fc6e913415fad7698057
Gerrit-Change-Number: 15920
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
