Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15791 )
Change subject: transaction: avoid locking for TransactionState::timestamp_ ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15791/5/src/kudu/tablet/ops/op.cc File src/kudu/tablet/ops/op.cc: http://gerrit.cloudera.org:8080/#/c/15791/5/src/kudu/tablet/ops/op.cc@35 PS5, Line 35: timestamp_(Timestamp()) > nit: this is not necessary after the changes in the signature of the Timest Ah, probably that's not enough due to those failures in WebserverCrawlITest.TestAllWebPages under TSAN. OK, that's interesting. Anyways, thank you for the new revision with the fix! -- To view, visit http://gerrit.cloudera.org:8080/15791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c6bc8b85a066426bcf4bc2d1c058bc75c1c38ec Gerrit-Change-Number: 15791 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 27 May 2020 21:57:48 +0000 Gerrit-HasComments: Yes
