Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16021 )
Change subject: [consensus] small cleanup on Peer::SignalRequest() ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16021/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16021/1//COMMIT_MSG@12 PS1, Line 12: worst the ca nit: the worst case http://gerrit.cloudera.org:8080/#/c/16021/1//COMMIT_MSG@14 PS1, Line 14: threads nit: blocking other tasks? http://gerrit.cloudera.org:8080/#/c/16021/1/src/kudu/consensus/consensus_peers.h File src/kudu/consensus/consensus_peers.h: http://gerrit.cloudera.org:8080/#/c/16021/1/src/kudu/consensus/consensus_peers.h@197 PS1, Line 197: // Lock that protects Peer state changes, initialization, etc. Could you update this to describe the new semantics of locking? E.g. seems like we don't need to hold peer_lock_ to read closed_, but we need it to update it. What other behaviors do callers need to be aware of? -- To view, visit http://gerrit.cloudera.org:8080/16021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I899aec0964bc404e6df3742bd48d0d049e52d900 Gerrit-Change-Number: 16021 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 02 Jun 2020 22:39:40 +0000 Gerrit-HasComments: Yes
