Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16027 )
Change subject: tablet_replica-test: refactor to pull out some useful code ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/16027/1/src/kudu/tablet/tablet_replica-test-base.h File src/kudu/tablet/tablet_replica-test-base.h: http://gerrit.cloudera.org:8080/#/c/16027/1/src/kudu/tablet/tablet_replica-test-base.h@45 PS1, Line 45: explicit TabletReplicaTestBase(const Schema& schema) > warning: single-argument constructors must be marked explicit to avoid unin Done http://gerrit.cloudera.org:8080/#/c/16027/1/src/kudu/tablet/tablet_replica-test-base.cc File src/kudu/tablet/tablet_replica-test-base.cc: http://gerrit.cloudera.org:8080/#/c/16027/1/src/kudu/tablet/tablet_replica-test-base.cc@56 PS1, Line 56: using kudu::rpc::MessengerBuilder; > warning: using decl 'Messenger' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16027/1/src/kudu/tablet/tablet_replica-test-base.cc@60 PS1, Line 60: using std::shared_ptr; > warning: using decl 'TabletHarness' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16027/1/src/kudu/tablet/tablet_replica-test-base.cc@64 PS1, Line 64: > warning: using decl 'unique_ptr' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16027/2/src/kudu/tablet/tablet_replica-test.cc File src/kudu/tablet/tablet_replica-test.cc: http://gerrit.cloudera.org:8080/#/c/16027/2/src/kudu/tablet/tablet_replica-test.cc@84 PS2, Line 84: using kudu::log::LogOptions; > warning: using decl 'LogOptions' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/16027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I912221d73b4d83bb967d91ca7592618b4a89d74c Gerrit-Change-Number: 16027 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 02 Jun 2020 23:56:09 +0000 Gerrit-HasComments: Yes
