Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15983 )
Change subject: [java] Support columnar row format in Java client. ...................................................................... Patch Set 6: (2 comments) This looks good to me, and it is backwards compatible. I just have a couple small outstanding comments. http://gerrit.cloudera.org:8080/#/c/15983/6/java/kudu-client/src/jmh/java/org/apache/kudu/client/RowResultIteratorBenchmark.java File java/kudu-client/src/jmh/java/org/apache/kudu/client/RowResultIteratorBenchmark.java: PS6: Can this be moved to the test package so it isn't shipped as a part of the main client jar? http://gerrit.cloudera.org:8080/#/c/15983/4/java/kudu-client/src/main/java/org/apache/kudu/client/RowDataFormat.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowDataFormat.java: http://gerrit.cloudera.org:8080/#/c/15983/4/java/kudu-client/src/main/java/org/apache/kudu/client/RowDataFormat.java@32 PS4, Line 32: public enum RowDataFormat { nit: I think this can live in AsyncKuduScanner right by the ReadMode enum. -- To view, visit http://gerrit.cloudera.org:8080/15983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I580c9bb48e797ca8de9d88e7892df6860eed7070 Gerrit-Change-Number: 15983 Gerrit-PatchSet: 6 Gerrit-Owner: Shuping Zhou <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 03 Jun 2020 18:44:29 +0000 Gerrit-HasComments: Yes
