Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 )
Change subject: KUDU-1422 resize ErrorCollector ...................................................................... Patch Set 3: Code-Review+1 > (1 comment) I see your point. Given the current code, the only way this can happen is if the instance of ErrorCollector is shared between several threads and is not initialized in a thread-safe way. If thread A instantiates ErrorCollector and then passes it on to another thread - all is good. If thread A assigns ErrorCollector to a non-volatile variable that can be accessed by another thread - we have a problem. So, either we have to declare maxCapacity as volatile or beware of thread safety when using ErrorCollector instances. I am OK with either approach. > (1 comment) -- To view, visit http://gerrit.cloudera.org:8080/16201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53731f6367aa84d6435b3bf2143e86164c8eaa1e Gerrit-Change-Number: 16201 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 16 Jul 2020 17:25:11 +0000 Gerrit-HasComments: No
