[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 )
Change subject: KUDU-1422 resize ErrorCollector ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/16201/5/java/config/spotbugs/excludeFilter.xml File java/config/spotbugs/excludeFilter.xml: http://gerrit.cloudera.org:8080/#/c/16201/5/java/config/spotbugs/excludeFilter.xml@183 PS5, Line 183: <Bug pattern="RV_RETURN_VALUE_IGNORED" /> > nit: you can combine this with the above match with an or (see PartialRow f Done http://gerrit.cloudera.org:8080/#/c/16201/4/java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java File java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java: http://gerrit.cloudera.org:8080/#/c/16201/4/java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java@104 PS4, Line 104: errorQueue.poll(); > Spotbugs check is failing because the return value is ignored. You can add Done -- To view, visit http://gerrit.cloudera.org:8080/16201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53731f6367aa84d6435b3bf2143e86164c8eaa1e Gerrit-Change-Number: 16201 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 Jul 2020 04:48:35 +0000 Gerrit-HasComments: Yes
