Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16337 )
Change subject: KUDU-2373: registered a flag validator with maintenance_manager_num_threads ...................................................................... Patch Set 2: (2 comments) You can run `make iwyu-fix` to fix the issue pointed by IWYU failure. Were you able to the validator by manually adjusting the gflag to lets say 0. http://gerrit.cloudera.org:8080/#/c/16337/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16337/2//COMMIT_MSG@7 PS2, Line 7: registered Nit: Registered http://gerrit.cloudera.org:8080/#/c/16337/2/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/16337/2/src/kudu/util/maintenance_manager.cc@65 PS2, Line 65: DEFINE_validator(maintenance_manager_num_threads, [](const char* /*n*/, int32 v) { return v > 0; }); Nit: I guess tidy bot would have complained but this line does look long. If longer than 100 columns can you move the lambda function to next line? -- To view, visit http://gerrit.cloudera.org:8080/16337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d Gerrit-Change-Number: 16337 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 13 Aug 2020 20:03:55 +0000 Gerrit-HasComments: Yes
