Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16388 )
Change subject: WIP - KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@128 PS1, Line 128: checkKuduProperties(table); > Shouldn't we do this after checking whether HMS sync is enabled? +1 http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@164 PS1, Line 164: return Should we call checkNoKuduProperties here as well? http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@172 PS1, Line 172: // If this request doesn't specify a Kudu table ID then allow it to proceed. : if (targetTableId == null) { : return; : } This case indicates that the table is a Kudu table but it does not has a table ID, right? Should this be a validate case? Or we should throw an exception to disallow Kudu table to not have an ID? -- To view, visit http://gerrit.cloudera.org:8080/16388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3588d72af1bb499202b47fca50a08876e13ea37 Gerrit-Change-Number: 16388 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Sep 2020 00:26:37 +0000 Gerrit-HasComments: Yes
