Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16424 )

Change subject: [threadpool] optimize queue overload detection
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16424/1/src/kudu/util/threadpool.h
File src/kudu/util/threadpool.h:

http://gerrit.cloudera.org:8080/#/c/16424/1/src/kudu/util/threadpool.h@348
PS1, Line 348: ssize_t
nit: can this be negative? If not, maybe just use size_t?



--
To view, visit http://gerrit.cloudera.org:8080/16424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01ca7419beba92d7067c60ef520811136d67587
Gerrit-Change-Number: 16424
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Sep 2020 19:12:20 +0000
Gerrit-HasComments: Yes

Reply via email to