Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16455 )
Change subject: [Java] Upgrade dependencies ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/16455/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16455/2//COMMIT_MSG@20 PS2, Line 20: - ranger 2.0.0 -> 2.1.0 Nice! We should also try upgrading the thirdparty build to use this. http://gerrit.cloudera.org:8080/#/c/16455/2/java/kudu-spark/build.gradle File java/kudu-spark/build.gradle: http://gerrit.cloudera.org:8080/#/c/16455/2/java/kudu-spark/build.gradle@31 PS2, Line 31: nit: extra space http://gerrit.cloudera.org:8080/#/c/16455/2/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: http://gerrit.cloudera.org:8080/#/c/16455/2/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@33 PS2, Line 33: import org.junit.Assert._ nit: should we try avoiding wildcards for scala too? Same with spark.sql.functions? -- To view, visit http://gerrit.cloudera.org:8080/16455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc61547b6844893085de8c0f7edee50d84a248cf Gerrit-Change-Number: 16455 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Sep 2020 19:44:15 +0000 Gerrit-HasComments: Yes
