Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16458 )
Change subject: [test] Fix Unix socket tests on macOS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16458/1/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/16458/1/src/kudu/rpc/rpc-test.cc@123 PS1, Line 123: string path = Substitute("/tmp/kudu-$0-$1", uuid, getpid()); > Here and elsewhere: the file isn't automatically removed when socket is clo GetTestDataDirectory() in src/kudu/util/test_util.h returns the path to the test directory. -- To view, visit http://gerrit.cloudera.org:8080/16458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I434e92e86fb87d1085c35b5d707d1238295192fb Gerrit-Change-Number: 16458 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Sep 2020 15:23:58 +0000 Gerrit-HasComments: Yes
