Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16556 )

Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16556/1/www/bootstrap/js/npm.js
File www/bootstrap/js/npm.js:

PS1:
> I don't think this is necessary, it seems to work fine without it, no error
I guess it's desirable to import as less as possible to keep it functional, 
unless it requires some non-trivial cherry-picking and patching.

>From that standpoint I'd simply remove this file since it's not going to be 
>used by Kudu anyways.



--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Oct 2020 18:14:19 +0000
Gerrit-HasComments: Yes

Reply via email to