Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16527 )
Change subject: KUDU-2612: initial implementation of TxnManager ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16527/3/src/kudu/master/txn_manager.h File src/kudu/master/txn_manager.h: http://gerrit.cloudera.org:8080/#/c/16527/3/src/kudu/master/txn_manager.h@109 PS3, Line 109: s the c > nit: can we call this highest_seen_txn_id_ to clarify which transaction ID Ah, seems like it is next_txn_id_ :) http://gerrit.cloudera.org:8080/#/c/16527/4/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/16527/4/src/kudu/transactions/txn_system_client.cc@142 PS4, Line 142: const auto ret = s.Wait(); : if (result.has_highest_seen_txn_id() && highest_seen_txn_id) { : *highest_seen_txn_id = result.highest_seen_txn_id(); : } Should this be a part of the next patch? Or is it required in this patch? -- To view, visit http://gerrit.cloudera.org:8080/16527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie952977a3ae5f625d1283389f0be8afb79df7d8c Gerrit-Change-Number: 16527 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 12 Oct 2020 22:55:34 +0000 Gerrit-HasComments: Yes
